Feature implementation from commits 5f922ff..45d4dfd #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now subset Type-1 fonts and no longer have a copy of ttconv. Make the font comparison table a grid table so we can use a colspan cell. Clarify that Type-1 fonts get used only in the usetex/pdf combination.
Signed-off-by: Emmanuel Ferdman <[email protected]>
Throw exception when alpha is out of bounds
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Co-authored-by: hannah <[email protected]>
Co-authored-by: hannah <[email protected]>
Co-authored-by: hannah <[email protected]>
Co-authored-by: hannah <[email protected]>
Update font-related documentation
TST: Fix runtime error checking NaN input to format_cursor_data
Fixed an off-by-half-pixel bug in image resampling when using a nonaffine transform (e.g., a log axis)
![codeowlai[bot]](https://avatars.githubusercontent.com/in/1259765?s=60&v=4){kind=small}
| raise TypeError(f"'alpha' must be numeric or None, not {type(alpha)}") | ||
| if not 0 <= alpha <= 1: | ||
| ValueError("'alpha' must be between 0 and 1, inclusive") | ||
| raise ValueError("'alpha' must be between 0 and 1, inclusive") |
There was a problem hiding this comment.
🐛 Correctness Issue
Missing 'raise' keyword causes silent validation failure.
The ValueError was being created but not raised, allowing invalid alpha values to silently pass validation and potentially cause rendering issues.
Current Code (Diff):
- ValueError("'alpha' must be between 0 and 1, inclusive")
+ raise ValueError("'alpha' must be between 0 and 1, inclusive")📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
Suggested change
| raise ValueError("'alpha' must be between 0 and 1, inclusive") | |
| raise ValueError("'alpha' must be between 0 and 1, inclusive") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
5f922ff..45d4dfdFiles Changed: 8 (5 programming files)
Programming Ratio: 62.5%
Commits included:
... and 7 more commits