fix(core): improve LegacyMigrationResolver pattern for artifactory registries
#5216
Conversation
When migrating from yarn@1 to yarn@3 some of scoped packages hosted in private repository weren't migrated properly. This PR removes __archiveUrl for them which solves problem.
merceyz
changed the title
LegacyMigrationResolver pattern for artifactory registries
| { | ||
| version: `1.0.0`, | ||
| resolved: `https://company.jfrog.io/company/api/npm/registry-name/@scope/package-name/-/@scope/package-name-1.0.0.tgz#eeeec1e4e8850bed0468f938292b06cda793bf34`, | ||
| expected: `npm:1.0.0::__archiveUrl=https%3A%2F%2Fcompany.jfrog.io%2Fcompany%2Fapi%2Fnpm%2Fregistry-name%2F%40scope%2Fpackage-name%2F-%2F%40scope%2Fpackage-name-1.0.0.tgz%23`, |
There was a problem hiding this comment.
That doesn't seem correct - we kept __archiveUrl because iirc Artifactory didn't support the "standard url patterns" (ie you can see here the tarball is inside https://<registry>/@scope/package-name/-/@scope/package-name-1.0.0.tgz, instead of https://<registry>/@scope/package-name/-/package-name-1.0.0.tgz).
Do they now support the standard url?
There was a problem hiding this comment.
I will need more info how to test this :) But for me this was problem with locally published scoped packages that were:
@scope/package-name/-/@scope/package-name and not
@scope/package-name/-/package-name
Currently on yarn@1 in yarn.lock we have:
resolved "https://artifactory.corp/artifactory/api/npm/virtual-node/@achrinza/node-ipc/-/node-ipc-9.2.6.tgz#75c89e95fe38ff9e3dd33a0d2681dc28f1c31f33"
for package from public and for internal:
resolved "https://artifactory.corp/artifactory/api/npm/virtual-node/@corp/package-name/-/@corp/package-name-48.0.14.tgz#708e2351f00fb5415c90fadc8e685d743be06595"
Other fix for me would be also to publish it under @scope/package-name/-/package-name but I'm not sure why npm does repeat @scope.
2 participants
What's the problem this PR addresses?
When migrating from yarn@1 to yarn@3 some of scoped packages hosted in private repository weren't migrated properly.
Fixes #5156 (bug description in issue)
...
How did you fix it?
This PR removes
__archiveUrlfor them which solves problem....
Checklist