Skip to content

Conversation

@paul-soporan
Copy link
Member

What's the problem this PR addresses?

pnpDataPath is the only PnP file whose location can be customized, which means that:

  • it's tied to the Yarn configuration
  • it doesn't adhere to our new specification
  • it makes it impossible for third-party tools implementing the PnP specification to use it without reading the Yarn configuration which doesn't make sense

How did you fix it?

Removed it.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan mentioned this pull request Aug 17, 2022
13 tasks
@arcanis arcanis merged commit 8963fc0 into master Aug 18, 2022
@arcanis arcanis deleted the paul/refactor/remove-pnpDataPath branch August 18, 2022 16:19
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants