Fluent on Button class stopped working

[OzanKurt]

It works for Column

It doesn't work for Button

[OzanKurt]

I am sorry but this was actually a breaking change. 😢

yajra/laravel-datatables-html@dd652c9#diff-d8dd76a4cd27a40c9d8812ddc0ebe070d8be6f213e74509f5e86fd429103211dR12

The __call method from Macroable overwritten the __call from Fluent

Macroable:

    /**
     * Dynamically handle calls to the class.
     *
     * @param  string  $method
     * @param  array  $parameters
     * @return mixed
     *
     * @throws \BadMethodCallException
     */
    public function __call($method, $parameters)
    {
        if (! static::hasMacro($method)) {
            throw new BadMethodCallException(sprintf(
                'Method %s::%s does not exist.', static::class, $method
            ));
        }

        $macro = static::$macros[$method];

        if ($macro instanceof Closure) {
            $macro = $macro->bindTo($this, static::class);
        }

        return $macro(...$parameters);
    }

Fluent:

    /**
     * Handle dynamic calls to the fluent instance to set attributes.
     *
     * @param  TKey  $method
     * @param  array{0: ?TValue}  $parameters
     * @return $this
     */
    public function __call($method, $parameters)
    {
        $this->attributes[$method] = count($parameters) > 0 ? reset($parameters) : true;

        return $this;
    }

[OzanKurt]

@yajra

I've fixed the issue by merging the __call methods of both.

yajra/laravel-datatables-html#227

Can we please merge this asap?

[yajra]

I agree and apologize for the BC. I already identified the issue via #3190 (comment) but I haven't had the chance to fix it. Thanks for the PR.

[OzanKurt]

Thank you!

[yajra]

Patch released on v11.6.1, thanks!

[OzanKurt]

I hate it when PHP cannot understand imports by itself sometimes!

Great spot! 👍🏻