Skip to content

Conversation

@yajra
Copy link
Owner

@yajra yajra commented Apr 21, 2021

This PR will allow make factory helper to accept constructor arguments like how Laravel's Event::dispatch() works.

class ProjectMembersDataTableHtml extends DataTableHtml
{
    public $project;

    public function __construct(Project $project)
    {
        $this->project = $project;
    }
...

Before PR:

$members = (new ProjectMembersDataTableHtml($project))->handle();

After PR:

$members = ProjectMembersDataTableHtml::make($project);

@yajra yajra merged commit 1e17733 into 4.0 Apr 21, 2021
@yajra yajra deleted the patch-make branch April 21, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants