Skip to content

Conversation

@luckys383
Copy link
Contributor

added support for Laravel 8.x if Models directory exists then use Models directory in namespace for model

PR for the issue Pointing to wrong model path when generating DataTable - Laravel 8

@luckys383
Copy link
Contributor Author

@yajra could you please review this PR and provide your feedback?

@yajra yajra added hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest labels Oct 22, 2020
@yajra yajra changed the title added support for Laravel 8.x if Models directory exists then use Mod… Added support for Laravel 8.x if Models directory exists. Oct 22, 2020
@yajra
Copy link
Owner

yajra commented Oct 22, 2020

PR Looks good, will try to check on actual project as soon as I can. Thanks!

@yajra yajra merged commit c255bf5 into yajra:4.0 Oct 31, 2020
@yajra yajra changed the title Added support for Laravel 8.x if Models directory exists. Fix model namespace for Laravel 8.x. Oct 31, 2020
@yajra
Copy link
Owner

yajra commented Oct 31, 2020

Released on v4.10.1 🚀 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants