Skip to content

Fix <use> with no contents #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix <use> with no contents #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5eb0f4
Fix <use> with no contents
edemaine Dec 6, 2023
38a2943
Add test
edemaine Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nodes/geometrynode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export abstract class GeometryNode extends GraphicsNode {

protected getBoundingBoxCore(context: Context): Rect {
const path = this.getCachedPath(context)
if (!path) {
if (!path || !path.segments.length) {
return [0, 0, 0, 0]
Copy link
Member

@yGuy yGuy Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a bounding box with zero width and height "located at 0,0" handled properly in the rest of the code?
When we calculate the union of two bounding boxes do we filter "empty" bounding boxes like this?
What's the bounding box of a point at (0,0)?

E.g. in yFiles, a truely empty bounding box uses negative width and height as sentinel values, so that you can distinguish between non-existing and infinitely small bounding box rectangles...

Copy link
Member

@HackbrettXXX HackbrettXXX Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this is not 100% exact at this point and [0,0,0,0] isn't handled specially on the caller side. However, throughout the codebase we use [0,0,0,0] for empty bounding boxes and this hasn't been an issue so far. We could improve this in a separate PR, but let's keep it like this for the moment.

}
let minX = Number.POSITIVE_INFINITY
Expand Down
1 change: 1 addition & 0 deletions test/common/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ window.tests = [
'style-sheets',
'svg-viewbox',
'svg-use',
'svg-use-empty',
'symbols',
'text-fill-stroke',
'text-placement',
Expand Down
Binary file added test/specs/svg-use-empty/reference.pdf
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions test/specs/svg-use-empty/spec.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.