-
Notifications
You must be signed in to change notification settings - Fork 1
Added clearing of cache groups #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Co-authored-by: Jonny Harris <[email protected]>
@pbearne I worry about the flush cache group automatically flushing everything. I like the approach here: pantheon-systems/wp-redis@db32e94 that only flushes if it's possible to target them. It feels like a safer approach. What we could do is, separately from the changes to core. Add support for groups to object cache libraries. The redis one above already implements it but I don't think any memcache ones do. I suspect it's because memcache has no concept of groups and therefore it's just a hash of the concatenation of the key and group most of the time, but we could pseudo implement it by having groups be a pointer to an incrementor and when you flush the cache group you're in essence just incrementing the group part of the cache key, which while not actually flushing the keys, would make them return false / repopulate them. |
added filter to allow plugin to adjust the called function
@sboisvert I have removed the failback |
# Conflicts: # src/wp-includes/class-wp-object-cache.php # tests/phpunit/tests/cache.php
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
…_groups' into INITS-115-Support_flushing_cache_groups
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Jonny Harris <[email protected]>
reverted test rename
You might want to revert these commits and just merge trunk into this branch. I am seeing a lot of changes that are unrelated to this PR. |
removed WP_Object_Cache_dummy class
removed WP_Object_Cache_dummy class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch looks solid now. Let's submit it to WP Core team and get feedback from the wider community.
And flush all if flush_group not supported
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
… file and set to false
Co-authored-by: Till Krüss <[email protected]>
Co-authored-by: Till Krüss <[email protected]>
WordPress/performance#38
https://core.trac.wordpress.org/ticket/4476
https://core.trac.wordpress.org/ticket/9773
solves #INITS-115
Trac ticket: https://core.trac.wordpress.org/ticket/4476
https://core.trac.wordpress.org/ticket/9773)