Skip to content

Conversation

@galtm
Copy link
Member

@galtm galtm commented Mar 1, 2025

In xspec/xspec#2075 (comment), @cmarchand suggests publishing oxygen-addon.xml at xspec.io. This pull request does that for the existing v3.2.0 add-on for which Oxygen users would point Oxygen to the URL https://github.com/xspec/xspec/raw/master/oxygen-addon.xml (instructions). The purpose of this PR is to make sure this new publishing location works and that we're happy with it, before asking users to change their Oxygen setting.

After this pull request is merged, Oxygen should be able to use the following URL to find and install the add-on: https://xspec.io/editors/oxygen/oxygen-addon.xml

I am open to suggestions about what the URL should be.

In this pull request,

  • The oxygen-addon.xml file is from the top level of the xspec/xspec repo, and I made two changes: I flattened the XInclude pointing to LICENSE because a LICENSE file in this repo might look as if it's the license for this repo rather than the license for the XSpec add-on code. Also, I redirected the XInclude pointing to latest.xhtml to adapt to the shallower directory hierarchy in this repo.
  • The latest.xhtml file is directly from the xspec/xspec repo, but I used a shallower directory hierarchy because it seemed simpler. The original file is at https://github.com/xspec/xspec/blob/0bef40c0dbed817717ff1b1a8043f367b368d33b/editors/oxygen/add-on/description/latest.xhtml

Testing done

I was able to install the add-on in Oxygen 24.1 and Oxygen 27.0, after running hugo locally and giving Oxygen this URL:
http://localhost:1313/editors/oxygen/oxygen-addon.xml

In one case, I had the v3.1.3 add-on previously installed, and Oxygen removed the v3.1.3 add-on when unpacking the new one. It also recognized the new one as an update of the old one.

image

@galtm galtm requested a review from cmarchand March 1, 2025 15:10
@galtm galtm added the oxygen Oxygen add-on label Mar 1, 2025
@galtm
Copy link
Member Author

galtm commented Mar 10, 2025

I'm going to merge this pull request. The stakes should be low because the URL https://xspec.io/editors/oxygen/oxygen-addon.xml hasn't been announced in the XSpec wiki or in any publicity channels.

@galtm galtm merged commit 233d0a1 into xspec:hugo Mar 10, 2025
@galtm
Copy link
Member Author

galtm commented Mar 10, 2025

I was able to install the add-on using Oxygen (26.1) and the URL https://xspec.io/editors/oxygen/oxygen-addon.xml after removing from my Oxygen preferences the other URLs that I've used in the past for installing the XSpec Oxygen add-on. I can see the com.oxygenxml\extensions\v26.1\frameworks\io.xspec.xspec\xspec-fee92fd453ac9e55e3c889df168ebc918fdc8485 folder in my local Oxygen data area, and I see the new src\reporter\test-report-colors-blackwhite.css file that is new in v3.2.0.

@galtm galtm deleted the oxygen-addon-3.2.0 branch March 23, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oxygen Oxygen add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant