-
Notifications
You must be signed in to change notification settings - Fork 48
Minor Ansible fixes #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Ansible fixes #247
Conversation
Now that Ansible- and CloudLab-related stuffs are out of tree, update the script accordingly - No need to checkout certain branch - xlab-uiuc/acto#247 is partly contained in the root of this repository, where HTTPS is already in use. Thus no more `sed`ing.
|
I'm closing this PR because everything here is contained in the root commit of I also suggest we completely remove Ansible stuffs in this repo at proper time, so that we maintain it all at one place. One issue that remains, though, is we always checkout the |
Since none of these are critical, I think we can discuss and test them after deadlines.
Details
requirements.txtat project root tooI actually didn't know whether it was on purpose to maintain two sources of Python dependencies (
requirements.txtanddata.yml)? If so, we can still have e.g.requirements/{common,dev,test,ansible}.txtOne thing to determine, whatever protocol, is which branch/tag/commit to fetch?
acto/scripts/ansible/acto.yaml
Line 19 in 4593e77
Currently we always and only get the tip of
mainthrough archives -- probably not what we desire. Maybe it's not a big deal if we clone instead, because we will have to login those machines after all and can manually checkout. On the other hand, changing this value on a per-branch basis looks... awkward. I don't know if there's cleverer ways.