chore(ci): build using python 3.8 #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you specify in the commit message what you designate as "CI"? This can be several different things: github actions, RPM %check, xcp-ng-tests runs... |
klmp200
force-pushed
the
fix_ci
branch
2 times, most recently
from
a652b7f to
8d6d05e
Compare
klmp200
changed the title
Wescoeur
requested changes
Nov 24, 2025
.github/workflows/main.yml
Outdated
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.x' | ||
| python-version: '3.8' # This is the closest available to 3.7 |
Member
There was a problem hiding this comment.
More explicit + correction regarding the used version:
This version is the closest available to the one currently used in production (3.6).
Member
|
Regarding the commit message, small suggestion: You can also explain why the |
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests. Signed-off-by: Antoine Bartuccio <[email protected]>
klmp200
changed the title
Millefeuille42
approved these changes
Nov 26, 2025
Wescoeur
approved these changes
Nov 27, 2025
Wescoeur
pushed a commit
that referenced
this pull request
Nov 28, 2025
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests. Signed-off-by: Antoine Bartuccio <[email protected]>
Wescoeur
pushed a commit
that referenced
this pull request
Dec 1, 2025
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests. Signed-off-by: Antoine Bartuccio <[email protected]>
Wescoeur
pushed a commit
that referenced
this pull request
Dec 1, 2025
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests. Signed-off-by: Antoine Bartuccio <[email protected]>
Wescoeur
pushed a commit
that referenced
this pull request
Dec 1, 2025
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests. Signed-off-by: Antoine Bartuccio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid python version mismatch that pulls incompatible dependencies in github actions when running unittests