Skip to content

Convert nD bounds arrays to (n-1)D vertex arrays #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dcherian
Copy link
Contributor

xref #163 which is the inverse of this

@dcherian dcherian requested a review from aulemahal July 13, 2021 20:37
@dcherian dcherian force-pushed the apply_ufunc_bounds_to_vertices branch from d047059 to d5ec667 Compare July 13, 2021 20:40
@dcherian dcherian force-pushed the apply_ufunc_bounds_to_vertices branch from d5ec667 to d927b18 Compare July 13, 2021 20:41
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #250 (d927b18) into main (ac9eba3) will increase coverage by 0.00%.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files          16       16           
  Lines        1849     1854    +5     
=======================================
+ Hits         1782     1787    +5     
  Misses         67       67           
Flag Coverage Δ
unittests 96.38% <95.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/helpers.py 95.12% <95.45%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9eba3...d927b18. Read the comment docs.

Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice generalization! Thanks!

(Sorry for the delay, I was on vacation for the last 3 weeks)

@dcherian
Copy link
Contributor Author

thanks for the review!

@dcherian dcherian merged commit 5185d95 into xarray-contrib:main Jul 26, 2021
@dcherian dcherian deleted the apply_ufunc_bounds_to_vertices branch July 26, 2021 21:12
@aulemahal aulemahal mentioned this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants