Fix CI failures caused by setup-ocaml@v3 #5912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah no Python2 in ubuntu-24.04, will have to wait with that one until |
last-genius
approved these changes
Aug 5, 2024
To better share caches with the main run. Once `feature/py3` is merged, we can move all this to 24.04. Signed-off-by: Edwin Török <[email protected]>
edwintorok
force-pushed
the
master
branch
5 times, most recently
from
f8bc317 to
f327f73
Compare
|
The part after v3- is still empty, seems to be quite difficult to get the OS version there. |
edwintorok
force-pushed
the
master
branch
3 times, most recently
from
4f3ac1b to
9efab52
Compare
This is a bug in setup-ocaml@v3 ocaml/setup-ocaml#839 Work it around by defining our own cache prefix based on runner OS version. Unfortunately the version itself doesn't seem to be available as a variable in GH actions. There is 'runner.os', but that is just a generic Linux, there is 'matrix.os', but that is only present when using a matrix, and there is '..container' which is only present when containers are used. Use another GH action to determine the version, and now the cache-prefix looks like this: ``` cache-prefix: v3-Ubuntu-22.04 ``` Signed-off-by: Edwin Török <[email protected]>
|
I think I found a solution by using another GH action that makes the runner's OS version available, I couldn't find anything built-in to Github Actions contexts that would provide this information. |
This was referenced Aug 5, 2024
GabrielBuica
approved these changes
Aug 5, 2024
Vincent-lau
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for ocaml/setup-ocaml#839.
Draft PR to check that it all works and creates correct cache keys.