CP-49811: Remove redundant method object from span name #5840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
approved these changes
Jul 16, 2024
We already have method_name so printing the method itself doesn't add anything. It also makes searching in Jaeger more difficult as the method includes its id. Signed-off-by: Steven Woods <[email protected]>
snwoods
force-pushed
the
private/stevenwo/CP-49811
branch
from
b075a70 to
28b16f4
Compare
|
^ Rebased on master to get the quality-gate fix |
bernhardkaindl
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have method_name so printing the method itself doesn't add anything. It also makes searching in Jaeger more difficult as the method includes its id.
You can see this in action here: http://rage.uk.xensource.com:16686/trace/46e188b3e42c0b2cec83af26e1d60bd8 (note the "class.instrument" spans)