Skip to content

Conversation

ashwin9390
Copy link
Contributor

@ashwin9390 ashwin9390 commented Jul 15, 2024

This PR contains the following changes,

  • Update test_mail-alarm.py to test with Python3
  • Move the test to the python3/tests directory
  • Replace the old method of copying the script to a temp directory and importing it as a module with the import_helper module from python3/tests
  • Remove the use of another temporary file to gather logged errors
  • Remove the obsolete nottest decorator
  • The test is now run against the Python3 version of mail-alarm
  • The test was also run against the original Python2 mail-alarm during the update, but this PR only updates the test for Python3
  • After this PR, there are no longer any Python2 tests left

Author :Bernhard Kaindl [email protected]
Committed by :Ashwinh [email protected]

Copy link
Collaborator

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described: Uses the new infrastructure for imports and cleans up the obsoleted code.

@bernhardkaindl bernhardkaindl changed the title Update scripts/test_mail-alarm.py to test with Python3 and move it Py3: Cleanup test_mail-alarm.py to use python3 test helpers an move it Jul 16, 2024
@bernhardkaindl bernhardkaindl merged commit 6e37eaf into xapi-project:feature/py3 Jul 16, 2024
@bernhardkaindl bernhardkaindl deleted the mv-and-fix-test_mail_alarm-py3 branch July 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants