CP-49931: mv scripts/xe-reset-networking to python3/bin
#5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jul 11, 2024
python3/bin/xe-reset-networking
Outdated
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU Lesser General Public License for more details. | ||
| """ | ||
| # pyright: reportPossiblyUnboundVariable=false |
There was a problem hiding this comment.
Why is it not worth declaring the variable instead?
There was a problem hiding this comment.
Initially, it was my recommendation to not touch the warnings (disable them) because the script's style is quite old (bad):
Many locations trigger this warning:
The reason was that I did not immediately see a clean way to fix all possibly unbound variable warnings.
The cause for the many unbound variables warnings is that the exception handling wasn't done nicely.
Now, to fix all of them, I had the idea to use a context manager handling it:
- In case you like it, I've pushed the fixes for
pyrightnow to the PR. Please check!
New commit:
CP-49931: mv scripts/xe-reset-networking to python3/bin, fix pyright
Fix pyright:
- Rework unclean exception handling using a contextmanager.
- Declare address and master in case of an Exception as well.
- Fix warning on unsupported escape sequence using a raw string.
Signed-off-by: Ashwinh <ashwin.h@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
approved these changes
Jul 11, 2024
bernhardkaindl
changed the title
bernhardkaindl
changed the title
scripts/xe-reset-networking to python3/bin
psafont
approved these changes
Jul 12, 2024
liulinC
approved these changes
Jul 15, 2024
|
There are some conflicts, this needs rebasing |
Working on it |
Fix pyright:
- Rework unclean exception handling using a contextmanager.
- Declare address and master in case of an Exception as well.
- Fix warning on unsupported escape sequence using a raw string.
- Removed python2 script check from pyproject.toml
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Ashwinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.
Sub task CP-49931: mv
scripts/xe-reset-networkingtopython3/binUpdate summary: @psafont asked:
@bernhardkaindl added:
@psafont: please check those fixes for it:
Added fixes for
pyrightunbound variable warnings:Fixed a "scary" pylint warning too: