Remove possible file descriptor leak if safe_close_and_exec fails #5596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Apr 26, 2024
fail is always used in combination with Printf.sprintf so combine the two. Signed-off-by: Frediano Ziglio <[email protected]>
More compact code. Signed-off-by: Frediano Ziglio <[email protected]>
"exe" variable is compute in mutiple functions, not very expensive to compute once. Reduce code. Signed-off-by: Frediano Ziglio <[email protected]>
Make sure we release the "sock" file descriptors in all cases. Add test trying to reproduce the issue passing an invalid file descriptor; not a perfect reproduction but failure in this function can happen for instance if daemon is restarted. Signed-off-by: Frediano Ziglio <[email protected]>
We just want information about the current process. Signed-off-by: Frediano Ziglio <[email protected]>
|
ping |
lindig
approved these changes
May 15, 2024
In case of getting the list of files we called Unix.readlink twice for every file descriptor. In case we wanted just the count we computed the list anyway. Factor out code to avoid calling function twice and do not compute the list is not needed. Signed-off-by: Frediano Ziglio <[email protected]>
psafont
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we release the
sockfile descriptors in all cases.Add test trying to reproduce the issue passing an invalid file descriptor; not a perfect reproduction but failure in this function can happen for instance if daemon is restarted.