Handle building with latest ocaml-xenstore
#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restrict was removed in o/xenstored upstream in 2017 in
dbc84d2983969bb47d294131ed9e6bbbdc2aec49, and in ocaml-xenstore recently.
Fixes this build error:
dune build @install --profile=release
File "cli/xs_client_cli.ml", line 224, characters 22-30:
224 | | Some domid -> restrict xs (int_of_string domid)
^^^^^^^^
Error: Unbound value restrict
Signed-off-by: Andrii Sultanov <[email protected]>
Now that 'restrict' has been deprecated and removed, no point in having these comments. Signed-off-by: Andrii Sultanov <[email protected]>
Contributor
Author
13 tasks
psafont
approved these changes
Jul 18, 2025
Contributor
Author
|
what's wrong with Github Actions on this PR???? |
Member
|
They don't seem to want to start, even after restarting them ... |
lindig
approved these changes
Jul 18, 2025
Contributor
Author
|
We'll need to create another release as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocaml-xenstorefinally removed long-deprecatedrestrict, drop it here as well.