Fix windows build #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Civetweb was updated to its latest released stable version, the build script for civet-sys now uses the cmake crate making compatibilty with Windows easy. The bindings were updated to reflect civetweb's upstream changes. The tests were modifed to using Carriage Return & Line Feed as Civet seems to be behving differently now with HTTP Requests using Line Feed as line separator.
Because the socket is configured with the SO_REUSEADDR flag on non-Windows systems, you can successfully launch multiple instance of a civet webserver on the same host-port pair. The test is now only run on windows platform because the socket is configured with the SO_EXCLUSIVEADDRUSE flag there.
3 tasks
|
👍 |
|
@alexcrichton Could you publish version |
|
Sure! Published now |
|
Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
This is the first step to get rust-lang/crates.io running on Windows.
Because I don't have access to an Apple device, this PR wasn't tested on macOS. However, I've been able to test a Windows version of crates.io and I get 0-failures after updating to this version of civet.
Civetweb was updated to its latest released stable version (1.9.1), the build
script for civet-sys now uses the cmake crate making compatibilty with
Windows easy.
The cmake build script: