refactor!: move to module-runner #1946
Open
+143
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lishaduck
force-pushed
the
module-runner
branch
from
f137b01 to
dbe4670
Compare
|
If tests pass, that should be good enough. |
aklinker1
approved these changes
Oct 27, 2025
| }, | ||
| "peerDependencies": { | ||
| "vite": "^5.4.19 || ^6.3.4 || ^7.0.0" | ||
| "vite": "^6.3.4 || ^7.0.0" |
There was a problem hiding this comment.
Perfect, was gonna call this out.
aklinker1
changed the title
|
I say than and then I whip out |
Life would be soooo much easier if Vitepress would just release Vite>5.
Related: wxt-dev#1214. Related: wxt-dev#1044.
lishaduck
force-pushed
the
module-runner
branch
2 times, most recently
from
a12076a to
42a8693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Breaking Change
Drop support for Vite <6
Overview
Drop
vite-nodein favor of Vite-nativerunnerImport, which is based onModuleRunner.Manual Testing
Good question... not entirely sure what fails the treeshake in the first place, but all the tests pass so I assume it loads the entrypoints at least. 🤷🏻♂️
Related Issue
Stacked on #1945.
Supersedes/closes #1884.