New implementation of the hooks generation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Nov 7, 2024
| namespace JohnBillion\WPHooksGenerator; | ||
| namespace WPHooks\Generator; |
There was a problem hiding this comment.
I do not know this faceless guy called "Hooks".
I like John better.
|
While you're at it, could you add this EditorConfig file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to extract the hooks information from files, this library uses WP Parser Lib which itself uses a very outdated version of
phpdocumentor/reflectionthat doesn't support newer versions of PHP. It only really works fully on PHP 7.4. See WordPress/phpdoc-parser#228 for details.Updating
phpdocumentor/reflectionin WP Parser Lib is proving to be a lot of effort. @otrocodigo has made a good effort in wp-hooks/parser#1 but it's not yet complete and needs further updates in this library in order to support it.I've also never been very happy with the depth of nested dependencies that result from this.
As an alternative approach, we can move the file parsing and hook extraction into this library and directly use
php-parserto extract the hook information (phpdocumentor/reflectionby default extracts a lot more info that we don't need). This simplifies the dependency tree and allows PHP 7.4 through 8.3 to be supported.