fix: Make sure the variable op_count is initialized #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
single-thread-reactor-op-count
branch
from
f485b82 to
b0cdd4b
Compare
miry
changed the title
miry
changed the title
miry
force-pushed
the
single-thread-reactor-op-count
branch
from
b0cdd4b to
0bb7edf
Compare
When run Reactor in the single thread mode, skips the Initialization of
the @op_count.
```
NoMethodError: undefined method '-' for nil
lib/crystalruby/reactor.rb:133:in 'CrystalRuby::Reactor.gc_due?'
lib/crystalruby/reactor.rb:121:in 'CrystalRuby::Reactor.invoke_gc_if_due!'
lib/crystalruby/reactor.rb:199:in 'CrystalRuby::Reactor.schedule_work!'
lib/crystalruby/function.rb:73:in 'block (2 levels) in TestTime#define_crystallized_methods!'
test/types/test_time.rb:30:in 'TestTime#test_it_can_do_time_math'`
```
miry
force-pushed
the
single-thread-reactor-op-count
branch
from
0bb7edf to
58247ca
Compare
wouterken
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found if set the Single Thread mode true then tests returns: