This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Re-implement a few model types in Swift #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
suggested changes
Dec 14, 2022
| @@ -0,0 +1,25 @@ | |||
| import Foundation | |||
|
|
|||
| @objcMembers public class RemoteComment: NSObject { | |||
| public var postID: NSNumber? | ||
| public var likeCount: NSNumber? | ||
| public var commentCount: NSNumber? | ||
| public var taxonomies: NSArray? |
Contributor
There was a problem hiding this comment.
Does Swift know about the underlying type here? If so, can we use a Swift collection?
mokagio
approved these changes
Dec 15, 2022
Contributor
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Approving to unblock as @jkmassel 's concern about NSArray have been addressed.
Contributor
Author
|
I've changed the base branch to the dedicated Swift migration branch, see #562 for more context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What says in the title 😄
Testing Details
This PR should be low risk, as it only changed type declaration.
versionin the.podspecfile.