Re-implement RemoteBlog and RemoteBlogOptionsHelper in Swift

[crazytonyli]

Description

Similar to #556, this PR is part of re-implementing Objective-C in Swift.

• Please check here if your pull request includes additional test coverage.
• I have considered updating the version in the .podspec file.

[mokagio]

Looking good. I tried to read the code, although I don't trust my eyes to be able to reliably pick up translation issues... 🤔

But:

• I trust your work
• We have unit tests
• If something breaks in this process it'll be a good chance to add more tests

[mokagio]

Do you know what a remote blog is? And what's the difference with a "non-remote (?)" blog?

[crazytonyli]

I think "remote" indicates it's an HTTP API model, which is defined by the WordPress API schema (hence the "remote" name?). A "non-remote" blog (or just Blog) means it's a custom model type defined by the app, which may have a different structure than the "remote" one.

[mokagio]

Chasing down these two imports, I noticed their footprint is minimal in this implementation. As far as I could see, only this method:

WordPressKit-iOS/WordPressKit/AccountServiceRemoteREST.m

Lines 386 to 393 in 8ecfcca

	- (NSArray *)remoteBlogsFromJSONArray:(NSArray *)jsonBlogs
	{
	NSArray *blogs = jsonBlogs;
	return [blogs wp_map:^id(NSDictionary *jsonBlog) {
	return [[RemoteBlog alloc] initWithJSONDictionary:jsonBlog];
	}];
	return blogs;
	}

Might it be useful to re-write it in Swift in the context of this PR?

[crazytonyli]

I intentionally started with the easy ones to translate. This AccountServiceRemoteREST falls into my harder basket, and will be dealt with after I have finished with the easy ones 🥲

[mokagio]

Sure.

Just to be clear, I was suggesting converting only that method, but I can see how adding a dedicated extension just for it would be wasteful given we'd remove it once the whole class is converted soon enough.

[mokagio]

I'm sure you thought of this, too, but at some point it'd be good to make this and the other types currently using JSONDictionary Decodable.

[crazytonyli]

Indeed. Once I've finished the Swift translation, I'll have a look at the NSDictionary usage across all the models. I'll probably start with specializing the argument type first, to be [String: Any] for example. I'm not sure about Decodable, as it's a more drastic change to the JSON parsing code. But I'll for sure considering adopting Decodable when I get to it. 👍