-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Move WordPressKit and Authenticator code into this repo #23366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@iangmaia Dangermattic check failed because this PR diff is huge... |
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23366-b781954 | |
| Version | 25.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b781954 | |
| App Center Build | WPiOS - One-Offs #10206 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23366-b781954 | |
| Version | 25.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b781954 | |
| App Center Build | jetpack-installable-builds #9255 |
|
Hey, is it based on Gio's recent proposal? I've also been advocating in favor of monorepos then, but I'm just curious if there was a decision about how the client that are not WP-iOS will consume it. If you have to download this repo, a shallow clone is 100 MB, which is a bit steep, but maybe not too bad if it's just Woo. |
It's per request of @jkmassel . The motivation is mainly around faster iteration, not so much about monorepo though. Woo doesn't actually use WPKit. Woo depends on WPKit simply because WPKit is a dependency of WPAuthenticator, which Woo does use. |
kean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- I was able to build and run it
- The code contains the latest change from WordPressKit-iOS's
trunk - Smoke tested the login flow
|
SonarCloud reported 13 issues: 7 high and 6 low priority. All 7 high priority issues are in unit tests. I'm going to ignore the issues for now. Danger check failed due to large diff in this PR. I'll also ignore that. I'll merge this PR as all the rest checks passed. |


They are still used as a CocoaPods pod.
You can ignore the first commit, because it's just copying the source code from the trunk branches, without any code changes. Only library and test code are moved over.
A quick smoke test should be sufficient: login, viewing posts, reader, notifications, etc.
Next step
I'll look into creating Xcode targets for them, so that we can run their unit tests locally. Also, that'll get us a lot closer to SPM.