Skip to content

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Jan 16, 2023

Fixes #19916

Description

Insights update pop-up was designed to be displayed for WordPress app after the app updates. However, now when the feature is only enabled for Jetpack app and the migration is happening, this pop-up is more intrusive than helpful.

p1673606982997039-slack-C0180B5PRJ4

Testing instructions

Case 1:

  1. Fresh install and open Jetpack
  2. Log in
  3. Confirm that "Insights update" pop up does not appear

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

  2. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Images & Videos

@staskus staskus added this to the 21.6 milestone Jan 16, 2023
@staskus staskus requested review from guarani and sla8c January 16, 2023 07:59
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19917-03556f3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19917-03556f3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@sla8c sla8c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staskus staskus merged commit 595e5e1 into trunk Jan 16, 2023
@staskus staskus deleted the task/19916-stats-revamp-disable-insights-update-pop-up branch January 16, 2023 16:57
@guarani guarani mentioned this pull request May 27, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stats Revamp: Remove Insights update pop-up

5 participants