Skip to content

Merge final release/21.0 #17382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2022
Merged

Merge final release/21.0 #17382

merged 3 commits into from
Oct 31, 2022

Conversation

AliSoftware
Copy link
Contributor

  • changelog/*.txt files updated with latest translations
  • values*/strings.xml updated with latest translations
    • Actually none in this PR, because all the app strings were already translated to 100% at the time we created the last beta, so those were already up-to-date in the repo
  • Version bumped in version.properties
  • WPAndroid submitted to Google for review
  • JPAndroid submitted to Google for review

@AliSoftware AliSoftware added the Releases Label related to managing releases label Oct 28, 2022
@AliSoftware AliSoftware added this to the 21.1 milestone Oct 28, 2022
@AliSoftware AliSoftware requested a review from a team October 28, 2022 14:09
@AliSoftware AliSoftware self-assigned this Oct 28, 2022
@AliSoftware AliSoftware enabled auto-merge October 28, 2022 14:09
AliSoftware
AliSoftware commented Oct 28, 2022
View reviewed changes
fastlane/metadata/android/en-US/full_description.txt
@@ -1,40 +1,40 @@
WordPress for Android puts the power of web publishing in your pocket. It’s a website creator and so much more!

Copy link
Contributor Author

@AliSoftware AliSoftware Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes in whitespaces in this file come from #17341 and the fact that android/en-US/*.txt metadata now come from being copied from WordPress/metadata/*.txt files instead of being extracted from the source of en-GB back when we relied on a dirty hack for them before (which led to a bug if en-GB didn't have a translation for them). So this is not surprising.

fastlane/metadata/android/en-US/short_description.txt
@@ -1 +1 @@
Easily build your website & blog. Create posts & track analytics from anywhere!
Easily build your website & blog. Create posts & track analytics from anywhere! No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change correspond to the new copy having a newline at end of file.

This comes from #17341 and the fact that android/en-US/*.txt metadata now come from being copied from WordPress/metadata/*.txt files instead of being extracted from the source of en-GB back when we relied on a dirty hack for them before (which led to a bug if en-GB didn't have a translation for them).

fastlane/metadata/android/en-US/title.txt
@@ -1 +1 @@
WordPress – Website Builder
WordPress – Website Builder No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change correspond to the new copy having a newline at end of file.

This comes from #17341 and the fact that android/en-US/*.txt metadata now come from being copied from WordPress/metadata/*.txt files instead of being extracted from the source of en-GB back when we relied on a dirty hack for them before (which led to a bug if en-GB didn't have a translation for them).

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17382-f85d149.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitf85d149
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17382-f85d149.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitf85d149
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

mokagio
mokagio approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • versionName dropping the rc suffix and versionCode bump in version.properties
  • strings.xml updates – N.A. as per PR description
  • release_notes.xml and changelogs/*.txt updates
  • Diff from PRs that made it into the release/ branch since the last beta – N.A.

@AliSoftware AliSoftware merged commit 484c910 into trunk Oct 31, 2022
@AliSoftware AliSoftware deleted the release/21.0 branch October 31, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mokagio mokagio mokagio approved these changes

Assignees

@AliSoftware AliSoftware

Labels

Releases Label related to managing releases

Projects

None yet

Milestone

21.1

Development

Successfully merging this pull request may close these issues.

3 participants

@AliSoftware @wpmobilebot @mokagio