Remove the redundant isLocalCatalogSupported dependency

Author: samiuelson

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosLocalCatalogSyncWorker.kt

@@ -10,7 +10,6 @@ import com.woocommerce.android.ui.woopos.tab.WooPosTabShouldBeVisible
 import com.woocommerce.android.ui.woopos.util.datastore.WooPosPreferencesRepository
 import dagger.assisted.Assisted
 import dagger.assisted.AssistedInject
-import org.wordpress.android.fluxc.model.SiteModel
 import kotlin.time.Duration.Companion.milliseconds
 
 @HiltWorker
@@ -26,7 +25,6 @@ constructor(
     private val logger: WooPosLogWrapper,
     private val timeProvider: DateTimeProvider,
     private val wooPosTabShouldBeVisible: WooPosTabShouldBeVisible,
-    private val isLocalCatalogSupported: WooPosIsLocalCatalogSupported,
     private val syncStatusChecker: WooPosFullSyncStatusChecker,
 ) : CoroutineWorker(appContext, workerParams) {
 
@@ -48,9 +46,13 @@ constructor(
             return Result.success()
         }
 
-        checkSyncRequirement()?.let { return it }
+        validateSyncStatus()?.let { return it }
 
-        val site = isCatalogSyncSupported() ?: return Result.failure()
+        // Site and catalog support already validated by validateSyncStatus()
+        val site = selectedSite.getOrNull() ?: run {
+            logger.e("Unexpected: Site is null after validation")
+            return Result.failure()
+        }
 
         logger.d("Starting FULL local catalog sync")
 
@@ -88,7 +90,7 @@ constructor(
     }
 
     @Suppress("ReturnCount")
-    private suspend fun checkSyncRequirement(): Result? {
+    private suspend fun validateSyncStatus(): Result? {
         val syncRequirement = syncStatusChecker.checkSyncRequirement()
         return when (syncRequirement) {
             is WooPosFullSyncRequirement.NotRequired -> {
@@ -127,20 +129,4 @@ constructor(
             false
         }
     }
-
-    @Suppress("ReturnCount")
-    private suspend fun isCatalogSyncSupported(): SiteModel? {
-        val site = selectedSite.getOrNull()
-        if (site == null) {
-            logger.w("No selected WooCommerce site found, skipping local catalog sync")
-            return null
-        }
-
-        if (!isLocalCatalogSupported(site.localId())) {
-            logger.d("Local catalog not supported for site")
-            return null
-        }
-
-        return site
-    }
 }