Return error instead of throwing in case site is null

Author: samiuelson

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFullSyncStatusChecker.kt

@@ -23,7 +23,10 @@ class WooPosFullSyncStatusChecker @Inject constructor(
     @Suppress("ReturnCount")
     suspend fun checkSyncRequirement(): WooPosFullSyncRequirement {
         val site = selectedSite.getOrNull()
-            ?: error("No site selected")
+        if (site == null) {
+            wooPosLogWrapper.e("Full sync check failed: No site selected")
+            return WooPosFullSyncRequirement.Error("No site selected")
+        }
 
         if (!isLocalCatalogSupported(site.localId())) {
             wooPosLogWrapper.d("Full sync check skipped: Local catalog not supported for site")

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFullSyncStatusCheckerTest.kt

@@ -81,18 +81,19 @@ class WooPosFullSyncStatusCheckerTest {
             assertThat(result).isInstanceOf(WooPosFullSyncRequirement.LocalCatalogDisabled::class.java)
         }
 
-    @Test(expected = IllegalStateException::class)
-    fun `given no site selected, when checkSyncRequirement called, then should throw error`() = runTest {
+    @Test
+    fun `given no site selected, when checkSyncRequirement called, then should return Error`() = runTest {
         // GIVEN
         whenever(selectedSite.getOrNull()).thenReturn(null)
 
         val sut = createSut()
 
         // WHEN
-        sut.checkSyncRequirement()
+        val result = sut.checkSyncRequirement()
 
         // THEN
-        // Exception is expected
+        assertThat(result).isInstanceOf(WooPosFullSyncRequirement.Error::class.java)
+        assertThat((result as WooPosFullSyncRequirement.Error).message).isEqualTo("No site selected")
     }
 
     @Test