Skip to content

Conversation

@developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın [email protected]

PTAL @dlorenc @jirfag

@developer-guy developer-guy requested a review from a team as a code owner February 11, 2023 21:14
@developer-guy
Copy link
Member Author

@jirfag, it looks like golangci-lint requires go to be installed onto the environment, am I right? I'm asking because I've added go as a runtime dep of the golangci-lint package in wolfi.

@dlorenc
Copy link
Member

dlorenc commented Feb 12, 2023

@jirfag, it looks like golangci-lint requires go to be installed onto the environment, am I right? I'm asking because I've added go as a runtime dep of the golangci-lint package in wolfi.

That sounds plausible, it probably shells out to go tools.

@ldez
Copy link

ldez commented Feb 12, 2023

Hello, yes golangci-lint requires Go and also diff.

FYI, it's useless to ping Denis: he has not been active on the project for several years.
I'm the current active core maintainer.

I recommend not pinging directly maintainers especially when you don't know the person, as this can be considered harassment. Remember that you are not alone to do that, and managing a popular OSS is already taking a lot of time.
I have no doubt this was done with good intentions but it should be avoided, the road to hell is paved with good intentions.
The right approach is to open an issue on the upstream project to explain your topic without pinging the maintainers. You can friendly ping the maintainers if there is no response after a certain time.

@kaniini
Copy link
Contributor

kaniini commented Feb 12, 2023

I do not believe there is any intent to annoy any upstream maintainers, but rather a desire to make them aware of the intent to include their package in the distribution, and to solicit any opinions about that intention.

@ldez
Copy link

ldez commented Feb 12, 2023

Don't take me wrong, I just trying to explain a recurring problem, it is neither against a person nor a project nor this PR. There is no major problem here, I'm trying to explain this just to improve the sanity of OSS maintainers.

Just a quick demo of the problem with this PR: there 3 messages each of them is pinging Denis.
After the first one, he can decide to unsubscribe but as the other messages are still continuing to ping him, he is forced to follow the topic.

I'm sure there are no bad intentions here but it is bad behavior.
I'm also sure that you can understand what I mean here.

Sorry for the off-topic, I hope I answered the original question in my previous message.

@imjasonh imjasonh added the blocked indicates there are blocking issues that need to be addressed before progress can be made label Feb 24, 2023
@developer-guy developer-guy mentioned this pull request Feb 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked indicates there are blocking issues that need to be addressed before progress can be made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants