Skip to content

Path exception #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Path exception #4

wants to merge 1 commit into from

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Oct 19, 2022

  • fix whitespace issues
  • remove JsonPointerException
  • add test cases per JsonPointer operation method

(Also try alternative approach passing $pathItems through JsonPointerException to JsonPatch)

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
PHP 38 (+1) 3975 (+174) 3085 (+130) 330 (+22) 560 (+22) 201 102K (+4.9K)

This exception is thrown in JsonPatch::apply whenever a JsonPointer
call fails.
@Silvan-WMDE
Copy link
Member

Changes are done as decribed above, ready for review.

@jakobw
Copy link
Member Author

jakobw commented Oct 21, 2022

We went with the approach in #5 instead.

@jakobw jakobw closed this Oct 21, 2022
@jakobw jakobw deleted the path-exception branch October 21, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants