Assets add exports for web usage #3552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure where is the right place to add explanation about that, WDYT? |
M-i-k-e-l
reviewed
Mar 9, 2025
| return {uri: require('./xMedium.png'), dimensions: {width: 24, height: 24}}; | ||
| }, | ||
| get xFlat() { | ||
| return {uri: require('./xFlat.png'), dimensions: {width: 24, height: 24}}; |
There was a problem hiding this comment.
I'm not sure about the size for all of these assets, for example xFlat has 16 in private
| @@ -0,0 +1,5 @@ | |||
| export const images = { | |||
| get gradient() { | |||
| return {uri: require('./gradient.png'), dimensions: {width: 56, height: 2}}; | |||
There was a problem hiding this comment.
doesn't look like.
This was referenced Mar 11, 2025
Closed
|
Closing this PR, moved to 3604. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Image in web we need to pass the
width and heightstyle props.Assets add exports for web usage that include the asset dimensions.
For now Iv'e add the same size to al the icons (24x24 which is the regular size).
Changelog
Assets support on web.
Additional info
MADS-4531