-
Notifications
You must be signed in to change notification settings - Fork 734
feat(switch): ensure minimum 48x48 hit target for better accessibility #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e1a5228
feat(switch): ensure minimum 48x48 hit target for better accessibility
devin-ai-integration[bot] bbd0a49
refactor: destructure props at top of render function
devin-ai-integration[bot] 7d8e4d9
refactor(switch): move hitSlop calculation to dedicated function
devin-ai-integration[bot] ea9007a
refactor(switch): rename getHitSlopSize to getAccessibleHitSlop
devin-ai-integration[bot] fed515e
feat(switch): allow hitSlop override while maintaining default access…
devin-ai-integration[bot] a4c29d9
fix(switch): remove redundant hitSlop prop and fix prop spreading order
devin-ai-integration[bot] 763fced
chore(switch): remove unused import
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should be allowed to override the
hitSlop