-
-
Notifications
You must be signed in to change notification settings - Fork 232
Version 2.x (WIP...) #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Version 2.x (WIP...) #1359
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 35.71% 35.58% -0.14%
==========================================
Files 152 152
Lines 34539 34702 +163
==========================================
+ Hits 12337 12350 +13
- Misses 21777 21929 +152
+ Partials 425 423 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@StefH, some feedback:
|
Thanks for your response. About 1: WireMock.Net is mostly used in unit tests. So how many % of those unit tests project are going to use an older framework like the one you mentioned? I think that supporting older frameworks in a main project and testing this in a unit test project is related but not always 1 to 1.... I will think on this and maybe support that one instead of 4.8 About 2: the question is how critical any security issue is because WireMock is used for testing, not for production code. |
It will be great. I have had similar discussions about other, testing only library - Verify. After 1,5 year author bringed back support for this old framework. I think that the requestor was .NET team.
I think that here are 2 aspects to consider: .NET SDK 9 for first release switchted settings to (then it was rollbacked, but some project kept it in place). I am not sure what is the current state: <PropertyGroup>
<NuGetAudit>true</NuGetAudit>
<NuGetAuditMode>all</NuGetAuditMode>
<NuGetAuditLevel>low</NuGetAuditLevel>
</PropertyGroup> With this + treat warnings as errors, which is pretty common, at least in my buble, it leads to the breaking compilation. Usually, there is a possibility to fix such changes basicaly by bumping transitive packages, but it is just inconvinient. IMO it is better to fix such cases centrally, The second aspect are security scans. I will consider OpenTelemetry as an example. Some end-users/companies making additional source code scans, not only shipped libraries. If we have any known vulnerable dependencies, there are at least yellow flags and we need to explain that the production code is not affected. With this, this project has strict rules to fix all such warnings. Thanks for maintaining this library, I know that it takes more time than people usually thinks. |
Version 2.x only supports: