WINDUP-4115 CVE upgrade css-tools #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
added
Ready to Review
auto-backport
carlosthe19916
approved these changes
May 10, 2024
ui-pf4/src/main/webapp/package.json
Outdated
| "proxy": "http://localhost:8080", | ||
| "homepage": "./", | ||
| "dependencies": { | ||
| "@adobe/css-tools": "^4.3.3", |
Member
There was a problem hiding this comment.
As this is not a direct dependency for the UI. It is better to set this line under the resolutions section of the package.json
Contributor
Author
There was a problem hiding this comment.
this line has been moved as suggested
carlosthe19916
requested changes
May 10, 2024
Member
carlosthe19916
left a comment
carlosthe19916
left a comment
There was a problem hiding this comment.
Same comment as windup/windup#1739
carlosthe19916
approved these changes
May 10, 2024
Member
carlosthe19916
left a comment
carlosthe19916
left a comment
There was a problem hiding this comment.
LGTM! Thanks @m-brophy
github-actions bot
pushed a commit
that referenced
this pull request
May 10, 2024
* WINDUP-4115 CVE upgrade css-tools * WINDUP-4115 place css-tools in resolutions section (cherry picked from commit b136f5a)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
m-brophy
added a commit
that referenced
this pull request
May 10, 2024
* WINDUP-4115 CVE upgrade css-tools * WINDUP-4115 place css-tools in resolutions section (cherry picked from commit b136f5a) Co-authored-by: Mark Brophy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUP-4115
https://issues.redhat.com/browse/WINDUP-4098
https://bugzilla.redhat.com/show_bug.cgi?id=2254559