[WINDUP-3892] - Upgrade htmlUnit dependency #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosthe19916
added
auto-backport
mrizzi
reviewed
Jun 7, 2023
Member
mrizzi
left a comment
mrizzi
left a comment
There was a problem hiding this comment.
Just figured out a small enhancement.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
* set Upgrade htmlunit dependency * Set scope:test (cherry picked from commit 9277950)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Jun 12, 2023
* set Upgrade htmlunit dependency * Set scope:test (cherry picked from commit 9277950) Co-authored-by: Carlos E. Feria Vila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUP-3892
The direct dependency injecting the htmlunit dependency is
org.jboss.arquillian.graphene:graphene-webdriver:2.5.4and we are already using the latest stable version of it https://mvnrepository.com/artifact/org.jboss.arquillian.graphene/graphene-webdriver . Therefore, as we can no upgrade the direct dependency, we need to exclude the htmlunit dependency fromorg.jboss.arquillian.graphene:graphene-webdriver:2.5.4and inject it as a direct dependency