Add Azure Spring Apps as the target for azure #907
Conversation
mrizzi
left a comment
mrizzi
left a comment
There was a problem hiding this comment.
Just a question to double check the default value change has been done on purpose.
| label: "azure-appservice", | ||
| value: "azure-appservice", | ||
| default: true, | ||
| default: false, |
There was a problem hiding this comment.
@showpune has the default value being changed on purpose from azure-appservice to azure-spring-apps?Because it's a kind of "breaking change" for the Windup Web Console users that are used to have azure-appservice as the default value for the Azure card in the Migration Paths page.
There was a problem hiding this comment.
Since we have a deadline for an upcoming release, the Windup team decided to take the most conservative approach with this change, pushing directly to this PR the c8d938b commit:
azure-appservicevalue is still the default target in theAzuretargetazure-spring-appsvalue has been added at the end
Screenshot reflects what described
@showpune further changes can be pushed in another PR 👍
mrizzi
added
auto-backport
* Add Azure Spring Apps as the target for azure * Reverted default Azure target to 'azure-appservice' --------- Co-authored-by: mrizzi <[email protected]> (cherry picked from commit 9013e09)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* Add Azure Spring Apps as the target for azure * Reverted default Azure target to 'azure-appservice' --------- Co-authored-by: mrizzi <[email protected]> (cherry picked from commit 9013e09) Co-authored-by: Zhiyong Li <[email protected]>
2 participants
Add the Azure Spring Apps as Azure Target
I also update the ruleset as windup/windup-rulesets#918