Skip to content

Conversation

@emarcusRH
Copy link
Contributor

@emarcusRH emarcusRH commented Feb 4, 2024

https://issues.redhat.com/browse/MTA-2174

Replace "windup-cli" plain text with attribute {mta-cli},
which resolves to "mta-cli"

Changes in the following files:
docs/topics/vs-code-extension-run-configuration.adoc REMOVED due to merge conflict
docs/topics/using-openrewrite-recipes.adoc
docs/topics/cli-run.adoc
docs/topics/review-reports.adoc
docs/topics/mavenize.adoc
docs/topics/manually-test-rules.adoc
docs/topics/intellij-idea-plugin-run-configuration.adoc
docs/topics/create-first-xml-rule.adoc REMOVED due to merge conflict

Previews:
https://deploy-preview-828--windup-documentation.netlify.app/docs/cli-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/rules-development-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/vs-code-extension-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/rules-development-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/intellij-idea-plugin-guide/master/

@netlify
Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for windup-documentation ready!

Name Link
🔨 Latest commit 88a2786
🔍 Latest deploy log https://app.netlify.com/sites/windup-documentation/deploys/65c53ed44a3a320008429ab2
😎 Deploy Preview https://deploy-preview-828--windup-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emarcusRH
Copy link
Contributor Author

I pushed one additional commit to update the document-attributes.adoc
placing the mtr-cli attribute inside the ifdef sections for MTA and MTR, so that the attribute is now resolved correctly for both documentation sets.

Copy link

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point of this PR LGTM.

I left some comments that should be addressed in this, or following PRs.

Apart from that I have two more consideration

  1. All mta-cli analysis commands should start now with mta-cli analyze instead of just mta-cli

  2. The available openrewrite rules table has hard-coded references to MTR

image

@emarcusRH
Copy link
Contributor Author

The main point of this PR LGTM.

I left some comments that should be addressed in this, or following PRs.

Apart from that I have two more consideration

1. All mta-cli analysis commands should start now with `mta-cli analyze` instead of just `mta-cli`

@abrugaro I created a separate PR to fix this:
#837

@emarcusRH emarcusRH mentioned this pull request Feb 8, 2024
@emarcusRH
Copy link
Contributor Author

these changes have been handled in a different PR - #847

@emarcusRH emarcusRH closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants