-
Notifications
You must be signed in to change notification settings - Fork 30
MTA_2174 insert mta-cli attribute instead of plain text windup-cli #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for windup-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I pushed one additional commit to update the document-attributes.adoc |
abrugaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point of this PR LGTM.
I left some comments that should be addressed in this, or following PRs.
Apart from that I have two more consideration
-
All mta-cli analysis commands should start now with
mta-cli analyzeinstead of justmta-cli -
The available openrewrite rules table has hard-coded references to MTR
|
|
these changes have been handled in a different PR - #847 |

https://issues.redhat.com/browse/MTA-2174
Replace "windup-cli" plain text with attribute {mta-cli},
which resolves to "mta-cli"
Changes in the following files:
docs/topics/vs-code-extension-run-configuration.adoc REMOVED due to merge conflict
docs/topics/using-openrewrite-recipes.adoc
docs/topics/cli-run.adoc
docs/topics/review-reports.adoc
docs/topics/mavenize.adoc
docs/topics/manually-test-rules.adoc
docs/topics/intellij-idea-plugin-run-configuration.adoc
docs/topics/create-first-xml-rule.adoc REMOVED due to merge conflict
Previews:
https://deploy-preview-828--windup-documentation.netlify.app/docs/cli-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/rules-development-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/vs-code-extension-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/rules-development-guide/master/
https://deploy-preview-828--windup-documentation.netlify.app/docs/intellij-idea-plugin-guide/master/