Issue #850: Merging wicket jquery UI into wicketstuff core (9.x) #861
Conversation
Kendo UI: Added factory methods CommandColumn#of(...) Kendo UI: **API BREAK** LinkPropertyColumn is now abstract, callback-url should now be supplied. 'datable' and 'button' arg have been removed from ctors
Kendo UI: added CommandButton#toJSONObject() Kendo UI: added ToolbarButton#toJSONObject()
Added KendoEffect 'flip'
- Adjust groupId - Integrated Wicket JQuery/Kendo modules into the build process - Adjusted versions - Moved new modules as subfolders under wicket-jquery-ui-parent to align with the structure of other submodules
|
@reckart I would modify description and remove otherwise we will lose backward compatibility :) |
|
Mind if we keep the old groupIds, we have a release that contains multiple groupIds. Do you know if that has implications when deploying to Maven Central / Nexus? |
|
Originally it was deployed to https://oss.sonatype.org (same as wicketstuff) After merge I can run release process, and we will check if there will be any issues :) |
reckart
force-pushed
the
refactoring/850-Merging-wicket-jquery-ui-into-wicketstuff-core-9.x
branch
from
1f7a8ed to
0c79fc5
Compare
reckart
force-pushed
the
refactoring/850-Merging-wicket-jquery-ui-into-wicketstuff-core-9.x
branch
from
0c79fc5 to
f315d12
Compare
reckart
force-pushed
the
refactoring/850-Merging-wicket-jquery-ui-into-wicketstuff-core-9.x
branch
from
f315d12 to
091ef57
Compare
- Use the old groupId for the Wicket JQuery UI / Kendo modules for backwards compatibility
reckart
force-pushed
the
refactoring/850-Merging-wicket-jquery-ui-into-wicketstuff-core-9.x
branch
from
091ef57 to
6d27a30
Compare
|
Ok, I have change the groupIds of the Wicket JQuery UI / Kendo modules back to the old one for backwards compatibility. Anything more to do before merging? |
|
Merged, I'll try to check everything locally ASAP! |
|
@reckart SNAPSHOT succesfully deployed to https://oss.sonatype.org/ |
|
Can someone suggest how to get filtered with this 1000+ commits PR usual shortlog is useless :(((( |
|
I don't find a way at the moment of excluding a certain commit or range of commits from the shortlog. My idea would be to check the authors of the original wicket-jquery repo and then manually remove most/all the authors from that from the shortlog for the current releases, assuming that there is no significant relevant overlap between the authors of the two repos or the contributions they have made to the two repos in the relevant time spans. |
|
Maybe: |
|
Thanks a million @reckart ! |
8 participants
Change groupIds to match wicketstuff(not for 9.x)Change artifactIds to match wicketstuff conventions(not for 9.x)Change module names to match wicketstuff conventions(not for 9.x)Change package names to match wicketstuff(not for 9.x)