pep8 problem! #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![stickler-ci[bot]](https://avatars.githubusercontent.com/in/15299?s=60&v=4){kind=small}
pvlib/pvsystem.py
Outdated
| return scale_voltage_current_power(data, | ||
| voltage=self.modules_per_string, | ||
| current=self.strings_per_inverter) | ||
| return scale_voltage_current_power(data,voltage=self.modules_per_string, current=self.strings_per_inverter) |
There was a problem hiding this comment.
E231 missing whitespace after ','
E501 line too long (115 > 79 characters)
pvlib/pvsystem.py
Outdated
| return scale_voltage_current_power(data, | ||
| voltage=self.modules_per_string, | ||
| current=self.strings_per_inverter) | ||
| voltage=self.modules_per_string, current=self.strings_per_inverter) |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
| """ | ||
| kwargs = _build_kwargs(['eta_inv_nom', 'eta_inv_ref'], | ||
| self.inverter_parameters) | ||
| kwargs = _build_kwargs(['eta_inv_nom', 'eta_inv_ref'], self.inverter_parameters) |
There was a problem hiding this comment.
E501 line too long (90 > 79 characters)
| The LocalizedPVSystem may have bugs due to the difficulty of | ||
| robustly implementing multiple inheritance. See | ||
| The LocalizedPVSystem may have bugs due to the difficulty of robustly implementing multiple inheritance. See |
There was a problem hiding this comment.
E501 line too long (112 > 79 characters)
|
I think this is a good idea. If Stickler proves annoying rather than helpful, I assume we can remove it later. |
Owner
Author
Yes. Looks like a simple change for repository admins. |
wholmgren
pushed a commit
that referenced
this pull request
May 31, 2024
* prototype (#1) * first iteration * dynamic period * docstring * feedback * linting * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * midpoint docstring * flak8 formatting * PR 1875 (#2) * kandersolar feedback (#3) * addressing feedback from Kandersolar * Review (#4) added hack for ISO periods in Pandas 0.25 and clearsky parameter maps * comment on pandas version * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Last minor changes * added test for _get_solcast * feat: add additional test coverage (#5) Co-authored-by: Hugh Cutcher <[email protected]> * linting --------- Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Adam R. Jensen <[email protected]> Co-authored-by: hugh-solcast <[email protected]> Co-authored-by: Hugh Cutcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvlib python pull request guidelines
Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.
You may submit a pull request with your code at any stage of completion.
The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.git diff upstream/master -u -- "*.py" | flake8 --diffBrief description of the problem and proposed solution (if not already fully described in the issue linked to above):