Bugfix: fds-input og xfds-form-input properties der ikke virkede #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et og brugt i eksempler som ikke virkede som det lovede
…oblemet med properties, og så opdagede jeg også lige eksempler der brugte "readonly" property som heller ikke virkede
|
Jeg har rent bevidst fjernet flere af de "v-bind=attrs" da jeg syntes det i brug-scenarierne blev lidt uklart hvor en attribute så betød hvis man sætte den på, fordi det ikke altid gav helt mening at den så havnede på det component. Eksempel Jeg mener at hvis vi skal bruge den direkte "forward" af attributes så skal det være helt klar og intuitivt hvor de attributter bliver "forward'et" til. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fds-input og xfds-form-input havde properties der var beskrevet og brugt i eksempler som ikke virkede som det lovede