Define "implements" checks using internal slots #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was #595. |
bzbarsky
approved these changes
Feb 25, 2019
index.bs
Outdated
| @@ -12364,6 +12359,20 @@ The value of the [=function object=]’s <code class="idl">name</code> property | |||
|
|
|||
| <h3 id="es-platform-objects">Platform objects implementing interfaces</h3> | |||
|
|
|||
| <div algorithm> | |||
| An ECMAScript value |value| <dfn id="es-is-platform-object">is a platform object</dfn> | |||
| if [$Type$](|value|) is Object and if |value| has a \[[PrimaryInterface]] internal slot. | |||
There was a problem hiding this comment.
So here is an interesting question: How should WindowProxy interact with all this? Probably followup fodder...
domenic
approved these changes
Feb 25, 2019
index.bs
Outdated
| @@ -12364,6 +12359,20 @@ The value of the [=function object=]’s <code class="idl">name</code> property | |||
|
|
|||
| <h3 id="es-platform-objects">Platform objects implementing interfaces</h3> | |||
|
|
|||
| <div algorithm> | |||
| An ECMAScript value |value| <dfn id="es-is-platform-object">is a platform object</dfn> | |||
There was a problem hiding this comment.
Just curious, why add a custom ID for this?
- Update the steps for instantiating a platform object, which everything theoretically calls into, and which sets the primary interface into a new internal slot [[PrimaryInterface]]. - Define the "implements" algorithm as checking the [[PrimaryInterface]] internal slot. The algorithm here is roughly in correspondence with the V8 implementation, where operation functions are allocated with a reference to a FunctionTemplate object (which is in corresondence with WebIDL interfaces). When checking the receiver of a method that came from WebIDL, the original prototype chain is traversed by looking at the FunctionTemplate's parent. The same FunctionTemplate is used in multiple JavaScript realms. Fixes #97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theoretically calls into, and which sets the primary interface into a new
internal slot [[PrimaryInterface]].
internal slot.
The algorithm here is roughly in correspondence with the V8 implementation,
where operation functions are allocated with a reference to a
FunctionTemplate object (which is in corresondence with WebIDL interfaces).
When checking the receiver of a method that came from WebIDL, the original
prototype chain is traversed by looking at the FunctionTemplate's parent.
The same FunctionTemplate is used in multiple JavaScript realms.
Fixes #97.
Preview | Diff