ReferenceError: window is not defined

[takahser]

When using ngx-kjua with Angular Universal (for SSR support), an error is thrown, when starting the node web server:

ReferenceError: window is not defined

[werthdavid]

I don't have any experience with Angular Universal sorry... I just found this, maybe it helps?
angular/universal#830 (comment)

[takahser]

I opened a PR to fix this: #3

[werthdavid]

Published 1.2.0, thanks for the PR 😄

[werthdavid]

@jcudzich stated:
"In @angular/common there is isPlatformBrowser method, so you don't need to use negation of isPlatformServer
And it's better to use https://angular.io/api/core/Renderer2 class to manipulate dom"

I reopened the issue so that I have that on my ToDo List

[takahser]

@werthdavid @jcudzich While I'm sure that some browser objects like window, document, etc. only exist in browser implementations of JS, I'm not sure if we should go as far as restricting kjua from getting loaded on any platform, other than the browser one. For example, NativeScript uses the platformBrowserDynamic and I'm not sure, what isPlatformBrowser would return in this case. What's more, regarding isPlatformWorkerApp, isPlatformWorkerUi, I'm not sure if they run on the browser as well?
Just thinking out loud here.

Regarding Renderer2, does this relate to this PR as well?

[werthdavid]

You're right. Since everything works fine now I'll leave it as it is. Just thought we could optimize a little bit 😉

[takahser]

I'm always open for a good discussion, so @jcudzich, please don't hesitate to elaborate further on this matter. 😄

[jcudzich]

@takahser Good observation about other platforms than the browser, I think you're right in this case.
Btw Renderer2 is just good habits in this case.