Add properties to TestCase for the two other result-types #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cube707
commented
Oct 24, 2024
EnricoMi
reviewed
Dec 20, 2024
its functionality is now handled by the class `FinalResult`, so it just leads to confusion between the two. The single usage of the constant can also be simplified by using its content directly
Cube707
force-pushed
the
testcases-statuses
branch
from
77816dc to
a04c5ce
Compare
|
Superseded by #145. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two missing properties
is_failureandis_errorto theTestCaseclass. They are implemented identically to the existingis_skippedproperty.We are using
junitparserto fill a table with all testcases and it feels really inconsistent to have three different ways to check for success (directly from propriety), failure (checking two other proprieties are unset) and errors (isinstancecheck on results). So this Pr would make it much easier and consistent.created in cooperation with @jonahRo