uos make puppet-wechat great again #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
有个lint 报错好像是项目之前就有的报错，是数据没有初始化，和本次提交无管 |
|
关注一下 |
|
mark |
huan
requested changes
Jul 14, 2022
Member
huan
left a comment
huan
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Please follow my reviews, and also remember to make sure the CI turns green before we can continue reviewing this PR!
package.json
Outdated
| "@types/qr-image": "^3.2.5", | ||
| "@types/request": "^2.48.8", | ||
| "@types/xml2js": "^0.4.9", | ||
| "qrcode-terminal": "^0.12.0", |
Member
There was a problem hiding this comment.
Please remove unrelated dependencies.
src/puppet-wechat.ts
Outdated
| launchOptions? : LaunchOptions | ||
| stealthless? : boolean | ||
| uos? : boolean | ||
| token? : string |
Member
There was a problem hiding this comment.
Could you please explain what's this token for? It seems that it does not been referenced in the new code.
added 3 commits
July 14, 2022 10:47
Member
|
LGTM |
huan
approved these changes
Jul 14, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uos 协议又可以重新使用了