Skip to content

Workaround: Render PixelBuffer in RTCMTLVideoView #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Workaround: Render PixelBuffer in RTCMTLVideoView #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48eb315
workaround for iOS also
hiroshihorie Dec 6, 2022
c815b34
comment
hiroshihorie Dec 6, 2022
b4df528
Merge branch 'm104_release' into pixelbuffer-render-workaround
hiroshihorie Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sdk/objc/components/renderer/metal/RTCMTLVideoView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,15 @@ - (void)renderFrame:(nullable RTC_OBJC_TYPE(RTCVideoFrame) *)frame {
return;
}

#if TARGET_OS_IPHONE
self.videoFrame = frame;
#elif TARGET_OS_OSX
// Rendering native CVPixelBuffer is not supported on OS X.
// Workaround to support RTCCVPixelBuffer rendering.
// RTCMTLRGBRenderer seems to be broken at the moment.
BOOL useI420 = NO;
if ([frame.buffer isKindOfClass:[RTC_OBJC_TYPE(RTCCVPixelBuffer) class]]) {
RTC_OBJC_TYPE(RTCCVPixelBuffer) *buffer = (RTC_OBJC_TYPE(RTCCVPixelBuffer) *)frame.buffer;
const OSType pixelFormat = CVPixelBufferGetPixelFormatType(buffer.pixelBuffer);
useI420 = pixelFormat == kCVPixelFormatType_32BGRA || pixelFormat == kCVPixelFormatType_32ARGB;
}
self.videoFrame = useI420 ? [frame newI420VideoFrame] : frame;
#endif
}

#pragma mark - Cross platform
Expand Down