fix: Restarting the playout without audio send streams makes the mic indicator off. #50
Conversation
| auto* adm = config_.audio_device_module.get(); | ||
| if (adm->Playing()) { | ||
| adm->StopPlayout(); | ||
| if (adm->InitPlayout() == 0) { |
There was a problem hiding this comment.
what does this mean? we are starting playout after stopping it?
There was a problem hiding this comment.
Through repeated tests, when the mode is changed to playback, the RTCAudioSession must be reset to stop the capture of the microphone.
There was a problem hiding this comment.
I'll add a commen describing the intent of this PR.
There was a problem hiding this comment.
got it, so it'd have to be restarted after Playout is stopped?
There was a problem hiding this comment.
If playout is stopped, we should not need to restart it, only need to deal with adm->StopRecording() && adm->Playing()
It means that after the last audio send stream is closed, 1,stop recording, 2, and then reset to release the mic capture state.
|
Replaced with a more reasonable PR. #52 |
2 participants
fix: Restarting the playout without audio send streams makes the mic indicator off.