Skip to content

Encoder does not reset when disabling a simulcast layer #68

@graszka22

Description

@graszka22

To reproduce on iOS:

  • have a video track with simulcast with 3 layers with H264 hardware encoding
  • disable one layer by setting encoding.isActive to false in peer connection
  • start screencast with H264 hardware encoding
  • the H264 encoder will fail to init with Failed to create compression session: -12915 error, this is caused by ios encoders limit exceeded (iOS max encoders limitation issue twilio/twilio-video-ios#17 ) however, we should use just 3 encoders (2 simulcast layers + 1 screencast)
  • this is probably caused by the encoder not being reset. There is a check here:
    // No need to reset when stream is inactive.
    that doesn't reset if layer is only disabled and nothing else changed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions