Skip to content

Commit 2ce9e01

Browse files
fippoWebRTC LUCI CQ
authored andcommitted
[merge to M104] sdp: temporarily relax channel requirements for statically assigned payload types
to allow for downstream users to upgrade. BUG=chromium:1338902 (cherry picked from commit c501f30) No-Try: true Change-Id: Ie1205ad2c9c1be3f4ed8e133b1a5e54afd04ebd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268193 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Tomas Gunnarsson <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#37501} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268469 Commit-Queue: Henrik Boström <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/branch-heads/5112@{#7} Cr-Branched-From: a976a87-refs/heads/main@{#37168}
1 parent 701c8ff commit 2ce9e01

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pc/webrtc_sdp.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3633,10 +3633,10 @@ bool ParseRtpmapAttribute(absl::string_view line,
36333633

36343634
AudioContentDescription* audio_desc = media_desc->as_audio();
36353635
for (const cricket::AudioCodec& existing_codec : audio_desc->codecs()) {
3636-
// TODO(crbug.com/1338902) re-add check for clockrate.
3636+
// TODO(crbug.com/1338902) re-add checks for clockrate and number of
3637+
// channels.
36373638
if (!existing_codec.name.empty() && payload_type == existing_codec.id &&
3638-
(!absl::EqualsIgnoreCase(encoding_name, existing_codec.name) ||
3639-
channels != existing_codec.channels)) {
3639+
(!absl::EqualsIgnoreCase(encoding_name, existing_codec.name))) {
36403640
rtc::StringBuilder description;
36413641
description
36423642
<< "Duplicate "

0 commit comments

Comments
 (0)