Chunked decoding and content access #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Apr 17, 2020
ikreymer
commented
- Support for chunked-decoding, fixes Chunk-encoded payload decoding #3
- Support for WARC record decoded vs raw access, document in README
- Record iteration, readline(), contentText() provides decoded access
- Update tests
make warcrecord iterable: decoded chunks, readline, readFully(decoded) raw access via readFully(false), recorder.reader add contentText() reader supports regular iter as well readline() supports maxLength README: update on accessing WARC content, raw and decoded bump to 1.1.2
ikreymer
added a commit
that referenced
this pull request
Apr 17, 2020
support for chunked decoding and raw/decoded content access (#3) make warcrecord iterable: decoded chunks, readline, readFully(decoded) raw access via readFully(false), recorder.reader decoded access via contentText(), record iteration, readline() reader supports regular sync iteration as well readline() supports maxLength, supported via LimitReader as well README: update on accessing WARC content, raw and decoded tests: add chunked decoding example cleanup dependencies, rename verb() -> method() build dist, bump to 1.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.